[PATCH v5 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports

Vivien Didelot vivien.didelot at savoirfairelinux.com
Thu Jan 19 14:13:12 PST 2017


Hi Gregory,

Gregory CLEMENT <gregory.clement at free-electrons.com> writes:

> From: Romain Perier <romain.perier at free-electrons.com>
>
> Some Marvell ethernet switches have internal ethernet transceivers with
> hardcoded phy addresses. These addresses can be greater than the number
> of ports or its value might be different than the associated port number.
> This is for example the case for MV88E6341 that has 6 ports and internal
> Port 1 to Port4 PHYs mapped at SMI addresses from 0x11 to 0x14.

Isn't there an hardware table used to map the PHY addresses on such chip?

> This commits fixes the issue by removing the condition in MDIO callbacks.
>
> Signed-off-by: Romain Perier <romain.perier at free-electrons.com>
> Reviewed-by: Andrew Lunn <andrew at lunn.ch>
> Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>

The patch is anyway still valid:

Reviewed-by: Vivien Didelot <vivien.didelot at savoirfairelinux.com>

Thanks,

        Vivien



More information about the linux-arm-kernel mailing list