[PATCHv4 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC

Chris Packham Chris.Packham at alliedtelesis.co.nz
Thu Jan 19 13:12:02 PST 2017


On 14/01/17 20:50, Chris Packham wrote:
> On 13/01/17 22:54, Sebastian Hesselbarth wrote:
>> On 13.01.2017 10:12, Chris Packham wrote:
>>> From: Kalyan Kinthada <kalyan.kinthada at alliedtelesis.co.nz>
>>>
>>> This pinctrl driver supports the 98DX3236, 98DX3336 and 98DX4251 SoCs
>>> from Marvell.
>>>
>>> Signed-off-by: Kalyan Kinthada <kalyan.kinthada at alliedtelesis.co.nz>
>>> Signed-off-by: Chris Packham <chris.packham at alliedtelesis.co.nz>
>>> Acked-by: Rob Herring <robh at kernel.org>
>>> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>
>>> ---
>>>
>>> Notes:
>>>     Changes in v2:
>>>     - include sdio support for the 98DX4251
>>>     Changes in v3:
>>>     - None
>>>     Changes in v4:
>>>     - Correct some discrepencies between binding and driver.
>>
>> Well, unfortunately I still see differences between the "gpio" in
>> the binding and "gpo" in the driver.
>>
>> Please go back to that list I sent you yesterday and fix them all.
>>
>
> I think you may have missed my initial reply [1]. Or I have missed your
> response to it. Long story short "gpo" is intentional because some of
> those pins can't be used as inputs. But if you still want me to change
> it I will.
>
> [1] - https://lkml.org/lkml/2017/1/12/117
>

Hi Sebastian,

Did you get a chance to consider this. Do you still want me to change 
gpo -> gpio given the information above?




More information about the linux-arm-kernel mailing list