[PATCH v2] ARM: dts: imx: Pass 'chosen' and 'memory' nodes
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Thu Jan 19 06:46:41 PST 2017
On Thu, Jan 19, 2017 at 12:35:40PM -0200, Fabio Estevam wrote:
> Hi Uwe,
>
> On Thu, Jan 19, 2017 at 12:13 PM, Uwe Kleine-König
> <u.kleine-koenig at pengutronix.de> wrote:
>
> > Would it be nice to add a comment about why this was added? Something to
> > prevent a cleanup like "remove empty nodes and invalid memory
> > configurations".
>
> Do you mean something like this?
>
> /* "chosen" and "memory" nodes are mandatory */
> chosen {};
> memory { device_type = "memory"; reg = <0 0>; };
Not very helpful comment. Something like:
/*
* The decompressor relies on a pre-existing chosen node to be
* available to insert the command line and merge other ATAGS
* info.
*/
Is it difficult to fix the decompressor?
I didn't understood the breakage regarding the memory node good enough
to suggest a comment for that.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list