[PATCH 1/2] dt-bindings: arm,gic: Fix binding example for a virt-capable GIC
Mark Rutland
mark.rutland at arm.com
Thu Jan 19 06:40:16 PST 2017
On Wed, Jan 18, 2017 at 10:53:30AM +0000, Marc Zyngier wrote:
> The joys of copy/paste: the example of a virtualization capable GIC
> in the DT binding was wrong, and propagated to dozens of platforms.
Could you please mention what's wrong (i.e. GICC is impossibly small in
the example).
>
> Oh well. Let's fix the source of the crap before tackling individual
> offenders.
>
> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>
> ---
> Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> index 5393e2a..a3d51ed 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> @@ -107,11 +107,11 @@ Required properties:
> Example:
>
> interrupt-controller at 2c001000 {
> - compatible = "arm,cortex-a15-gic";
> + compatible = "arm,gic-400";
I'm happy with this change in the spirit of making this more generally
applicable, even if it's not a bug as such. Please mention this as a
related cleanup in the commit message.
With those fixed up:
Acked-by: Mark Rutland <mark.rutland at arm.com>
Thanks,
Mark.
> #interrupt-cells = <3>;
> interrupt-controller;
> reg = <0x2c001000 0x1000>,
> - <0x2c002000 0x1000>,
> + <0x2c002000 0x2000>,
> <0x2c004000 0x2000>,
> <0x2c006000 0x2000>;
> interrupts = <1 9 0xf04>;
> --
> 2.1.4
>
More information about the linux-arm-kernel
mailing list