[PATCH v2 2/2] arm64: dts: exynos: Add regulators for Vbus and Vbus-Boost

[Krzysztof Kozlowski]

On Wed, Jan 18, 2017 at 5:20 AM, pankaj.dubey <pankaj.dubey at samsung.com> wrote:
>
>
> On Tuesday 17 January 2017 11:58 PM, Krzysztof Kozlowski wrote:
>> On Tue, Jan 17, 2017 at 08:34:04PM +0530, Pankaj Dubey wrote:
>>> From: Vivek Gautam <gautamvivek1987 at gmail.com>
>>>
>>> Adding fixed voltage regulators for Vbus and Vbus-boost required
>>> by USB 3.0 DRD controller on Exynos7-espresso board.
>>>
>>> Reviewed-by: Javier Martinez Canillas <javier at osg.samsung.com>
>>> Signed-off-by: Vivek Gautam <gautamvivek1987 at gmail.com>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey at samsung.com>
>>
>> Same as patch 1.
>>
>
> OK, will update.
>
>>> ---
>>>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 45 +++++++++++++++++++++++++
>>>  1 file changed, 45 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> index 9cf73cf..8d5abdd 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> @@ -13,6 +13,7 @@
>>>  #include "exynos7.dtsi"
>>>  #include <dt-bindings/interrupt-controller/irq.h>
>>>  #include <dt-bindings/clock/samsung,s2mps11.h>
>>> +#include <dt-bindings/gpio/gpio.h>
>>>
>>>  / {
>>>      model = "Samsung Exynos7 Espresso board based on EXYNOS7";
>>> @@ -33,6 +34,29 @@
>>>              device_type = "memory";
>>>              reg = <0x0 0x40000000 0x0 0xC0000000>;
>>>      };
>>> +
>>> +    usb30_vbus_reg: regulator-usb30 {
>>> +            compatible = "regulator-fixed";
>>> +            regulator-name = "VBUS_5V";
>>> +            regulator-min-microvolt = <5000000>;
>>> +            regulator-max-microvolt = <5000000>;
>>> +            gpio = <&gph1 1 GPIO_ACTIVE_HIGH>;
>>> +            pinctrl-names = "default";
>>> +            pinctrl-0 = <&usb30_vbus_en>;
>>> +            enable-active-high;
>>> +    };
>>> +
>>> +    usb3drd_boost_5v: regulator-usb3drd-boost {
>>> +            compatible = "regulator-fixed";
>>> +            regulator-name = "VUSB_VBUS_5V";
>>> +            regulator-min-microvolt = <5000000>;
>>> +            regulator-max-microvolt = <5000000>;
>>> +            gpio = <&gpf4 1 GPIO_ACTIVE_HIGH>;
>>> +            pinctrl-names = "default";
>>> +            pinctrl-0 = <&usb3drd_boost_en>;
>>> +            enable-active-high;
>>> +    };
>>> +
>>>  };
>>>
>>>  &fin_pll {
>>> @@ -366,3 +390,24 @@
>>>      vqmmc-supply = <&ldo2_reg>;
>>>      disable-wp;
>>>  };
>>> +
>>> +&usbdrd_phy {
>>> +    vbus-supply = <&usb30_vbus_reg>;
>>> +    vbus-boost-supply = <&usb3drd_boost_5v>;
>>> +};
>>> +
>>> +&pinctrl_bus1 {
>>> +    usb30_vbus_en: usb30-vbus-en {
>>> +            samsung,pins = "gph1-1";
>>> +            samsung,pin-function = <1>;
>>
>> Javier mentioned it, please use EXYNOS_PIN_FUNC_OUTPUT
>>
>
> Yes, but as it's not taken care in existing dts for other pin
> definitions, so a Javier mentioned, this can be taken care as a separate
> patch for all pin definitions? Or do you want me to first add patch
> converting all these with macros and then on top of add this usb related
> pin definitions.

For new code let's use the macros even if entire file is not converted
(yet). The same like mixture of values and GPIO_ACTIVE_* macros. If
you wish to convert the file to macros, feel free to go. But I see it
as separate patch.

Best regards,
Krzysztof