[PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT

Mark Rutland mark.rutland at arm.com
Tue Jan 17 04:29:21 PST 2017

On Tue, Jan 17, 2017 at 06:18:12AM -0600, Timur Tabi wrote:
> Fu Wei wrote:
> >        pr_err(FW_BUG "too many frames, ARMv8 spec only allows 8.\n");
> pr_err(FW_BUG "too many frames, ARMv8 spec only allows %u.\n",

While I don't see ARCH_TIMER_MEM_MAX_FRAMES changing, this would be
nicer to ensure the result obviously matches.

As for wording, I'd perfer:

	pr_err(FW_BUG "too many frames, only %u are permitted.\n",

... so as to avoid any confusion between spec versions and so on. We can
reconsider the message if/when that changes.


More information about the linux-arm-kernel mailing list