[PATCH 2/3] dts: teach newer i.MX machines to have the i.MX35 type watchdog

Vladimir Zapolskiy vz at mleia.com
Mon Jan 16 13:48:40 PST 2017

On 01/16/2017 10:43 PM, Uwe Kleine-König wrote:
> On Mon, Jan 16, 2017 at 04:35:26PM -0200, Fabio Estevam wrote:
>> On Mon, Jan 9, 2017 at 7:50 AM, Uwe Kleine-König
>> <u.kleine-koenig at pengutronix.de> wrote:
>>> Only i.MX35 and newer feature a WMCR register that should be written to. Older
>>> SoCs hang when this address is written.
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>> Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>
>> Only a minor nit: Subject could: ARM: dts: imx: teach...
> Ack. To reference the commit id of the first patch in the third I can
> prepare a branch to pull. There I'd fix the Subject. Shawn, is this OK?

This is too early for changes, which are not reviewed by Linux watchdog masters.

As I emphasized multiple times in our discussions your series is organized
improperly, it has interdependencies between DTS and driver, it lacks
atomicity feature of a proper fix, in the middle it breaks backward compatibility
with old DTB, all that makes it impossible to send an atomic fix for linux-stable,
some of the changes are captured from mine ones without preserving the authorship
or even a reported-by credit.

With best wishes,

More information about the linux-arm-kernel mailing list