[PATCH 2/3 v2] iio: adc: break out common code from SPMI VADC
linus.walleij at linaro.org
Tue Jan 10 00:54:01 PST 2017
On Fri, Dec 30, 2016 at 8:01 PM, Jonathan Cameron <jic23 at kernel.org> wrote:
> On 15/12/16 22:48, Linus Walleij wrote:
>> The SPMI VADC and the earlier XOADC share a subset of
>> common code, so to be able to use the same code in both
>> drivers, we break out a separate file with the common code,
>> prefix exported functions that are no longer static with
>> qcom_* and bake an object qcom-vadc.o that contains both
>> files: qcom-vadc-common.o and qcom-spmi-vadc.o.
>> Cc: linux-arm-kernel at lists.infradead.org
>> Cc: linux-arm-msm at vger.kernel.org
>> Cc: Ivan T. Ivanov <iivanov.xz at gmail.com>
>> Cc: Andy Gross <andy.gross at linaro.org>
>> Cc: Bjorn Andersson <bjorn.andersson at linaro.org>
>> Cc: Stephen Boyd <sboyd at codeaurora.org>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
>> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> Looks superficially fine, but I'm guessing will need a respin
> as we have a fair bit of new stuff (and a couple of fixes) going
> through this driver at the moment.
> All but the two fixes I posted a few mins ago are in my testing
> branch and should go to Greg once I have confirmed testing on
> those two fixes.
I looked at the git and "testing"
contains a top commit named "guessing" fixing some 64bit
artithmetic (which looks correct) in the driver, shall I simply
rebase on top of that and hope for the best? :)
More information about the linux-arm-kernel