[PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC
sean.wang at mediatek.com
Thu Jan 5 23:41:30 PST 2017
Thank for your reminder. I will refine the code based on your work.
to have elegant code and easy error handling.
On Fri, 2017-01-06 at 12:43 +0900, Andi Shyti wrote:
> Hi Sean,
> > + ir->rc = rc_allocate_device();
> Yes, you should use devm_rc_allocate_device(...)
> Besides, standing to this patch which is not in yet:
> rc_allocate_device should provide the driver type during
> allocation, so it should be:
> ir->rc = rc_allocate_device(RC_DRIVER_IR_RAW);
> and this line can be removed:
> > + ir->rc->driver_type = RC_DRIVER_IR_RAW;
> I don't know when Mauro will take the patch above.
More information about the linux-arm-kernel