[PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other
Krzysztof Kozlowski
krzk at kernel.org
Tue Jan 3 02:01:19 PST 2017
On Tue, Jan 3, 2017 at 11:58 AM, Andi Shyti <andi.shyti at samsung.com> wrote:
> Hi Krzysztof,
>
>> > Currently tm2e dts includes tm2 but there are some differences
>> > between the two boards and tm2 has some properties that tm2e
>> > doesn't have.
>> >
>> > That's why it's important to keep the two dts files independent
>> > and put all the commonalities in a tm2-common.dtsi file.
>> >
>> > Signed-off-by: Andi Shyti <andi.shyti at samsung.com>
>> > Signed-off-by: Jaechul Lee <jcsing.lee at samsung.com>
>> > ---
>> > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 1046 ++++++++++++++++++++
>> > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1033 +------------------
>> > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 2 +-
>> > 3 files changed, 1049 insertions(+), 1032 deletions(-)
>> > create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>>
>> I would like to see here the rename and diff from it. Not entire delta
>> (deletions and addons). It is not possible to compare it... I think
>> git supports it by default with similarity of 50%.
>
> I understand, it's indeed quite cryptic to understand. But all
> the diff algorithms (patience, minimal, histogram, myers) give
> the same result. I don't know how to make it better.
>
> I could split this patch, but this also means breaking tm2's
> functionality, which looks worse.
>
> Please tell me if you know a better way for generating the patch.
git format-patch -M95%?
Krzysztof
More information about the linux-arm-kernel
mailing list