[PATCH net-next v7 2/2] net: ethernet: socionext: add AVE ethernet driver
David Miller
davem at davemloft.net
Tue Dec 26 09:58:15 PST 2017
From: Kunihiko Hayashi <hayashi.kunihiko at socionext.com>
Date: Thu, 21 Dec 2017 20:12:56 +0900
> + writel(AVE_TXDC_ADDR_START
> + | (((priv->tx.ndesc * priv->desc_size) << 16) & AVE_TXDC_SIZE),
> + priv->base + AVE_TXDC);
...
> + writel(AVE_RXDC0_ADDR_START
> + | (((priv->rx.ndesc * priv->desc_size) << 16) & AVE_RXDC0_SIZE),
> + priv->base + AVE_RXDC0);
...
> + cmdsts = AVE_STS_OWN | AVE_STS_1ST | AVE_STS_LAST
> + | (skb->len & AVE_STS_PKTLEN_TX_MASK);
Please do not begin lines with operators, instead put them at the end
of the previous line, f.e.:
cmdsts = AVE_STS_OWN | AVE_STS_1ST | AVE_STS_LAST |
(skb->len & AVE_STS_PKTLEN_TX_MASK);
Thank you.
More information about the linux-arm-kernel
mailing list