[PATCH v2 3/5] mtd: nand: replace pxa3xx_nand driver by its rework called marvell_nand
Robert Jarzmik
robert.jarzmik at free.fr
Sat Dec 23 13:13:48 PST 2017
Boris Brezillon <boris.brezillon at free-electrons.com> writes:
>> What I would propose instead is :
>> - keep both the new marvell nand driver and the old pxa3xx_nand driver
>> - switch pxa_defconfig to compile them both
>
> Didn't notice you were suggesting to compile both, which doesn't work
> because both drivers match the same devices, and only one of them
> can actually claim the device (likely the first one to register to the
> device model). So, to make it safe you need to have a
>
> depends on !MTD_NAND_PXA3xx
>
> in your MTD_NAND_MARVELL entry, which means only one driver can be
> compiled.
Mmm... that is I didn't explain to you what pxa_defconfig is designed for.
This defconfig is not for any board actually, it rather is a build coverage
tool.
> So let's find a way to fix the remaining issues you have instead of delaying
> the inevitable.
It's up to you of course, as long as my boards don't break, and nothing breaking
them is merged, I'm fine with it. It's just not the approach I usually choose,
I'm rather a 2-step guy, ie. merge the new one, then merge the switch (which can
be reverted easilly).
Cheers.
--
Robert
More information about the linux-arm-kernel
mailing list