[PATCH 4/4] [v4] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002

Timur Tabi timur at codeaurora.org
Wed Dec 13 07:18:49 PST 2017


On 12/13/2017 08:46 AM, Timur Tabi wrote:
> 
>> Please, read my comment again. The key part of the phrase:
>> "Use members of struct device_driver"
>>
>> So, do not move the IDs. There are examples in the kernel how to access
>> it.
> 
> Sorry, I don't understand what you're talking about.  I don't see how I 
> can call
> 
>      const struct acpi_device_id *id =
>          acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
> 
> without having qdf2xxx_acpi_ids already defined previously.  And without 
> the 'id', I can't figure out whether I've probed via QCOM8001 or QCOM8002.

I think I found it.  Are you talking about doing this instead:

id = acpi_match_device(pdev->dev.driver->acpi_match_table, &pdev->dev);

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.



More information about the linux-arm-kernel mailing list