[PATCH v2] PCI: keystone: fix interrupt-controller-node lookup

Johan Hovold johan at kernel.org
Mon Dec 11 02:29:55 PST 2017


On Fri, Nov 17, 2017 at 02:38:31PM +0100, Johan Hovold wrote:
> Fix child-node lookup during initialisation which was using the wrong
> OF-helper and ended up searching the whole device tree depth-first
> starting at the parent rather than just matching on its children.
> 
> To make things worse, the parent pci node could end up being prematurely
> freed as of_find_node_by_name() drops a reference to its first argument.
> Any matching child interrupt-controller node was also leaked.
> 
> Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver")
> Cc: stable <stable at vger.kernel.org>     # 3.18
> Acked-by: Murali Karicheri <m-karicheri2 at ti.com>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>
> Signed-off-by: Johan Hovold <johan at kernel.org>
> ---
> 
> v2
>  - amend commit message and mention explicitly that of_find_node_by_name()
>    drops a reference to the start node
>  - add Murali's and Lorenzo's acks

This one hasn't shown up in linux-next, so sending a reminder to make
sure it doesn't fall between the cracks.

Thanks,
Johan



More information about the linux-arm-kernel mailing list