[PATCH v3 5/8] PM / ACPI: Split acpi_lpss_suspend_late|resume_early()
Ulf Hansson
ulf.hansson at linaro.org
Tue Aug 29 07:56:47 PDT 2017
Move the code which is special to ACPI LPSS into separate functions. This
may clarify the code a bit, but the main purpose of this change, is instead
to prepare for additional changes on top. Ideally the following changes
should then become easier to review.
Signed-off-by: Ulf Hansson <ulf.hansson at linaro.org>
---
Changes in v3:
- None.
---
drivers/acpi/acpi_lpss.c | 29 +++++++++++++++++++++++------
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 0c84d15..e726173 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -717,22 +717,28 @@ static void acpi_lpss_dismiss(struct device *dev)
}
#ifdef CONFIG_PM_SLEEP
-static int acpi_lpss_suspend_late(struct device *dev)
+static int lpss_suspend_late(struct device *dev)
{
struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));
+
+ if (pdata->dev_desc->flags & LPSS_SAVE_CTX)
+ acpi_lpss_save_ctx(dev, pdata);
+
+ return acpi_dev_suspend_late(dev);
+}
+
+static int acpi_lpss_suspend_late(struct device *dev)
+{
int ret;
ret = pm_generic_suspend_late(dev);
if (ret)
return ret;
- if (pdata->dev_desc->flags & LPSS_SAVE_CTX)
- acpi_lpss_save_ctx(dev, pdata);
-
- return acpi_dev_suspend_late(dev);
+ return lpss_suspend_late(dev);
}
-static int acpi_lpss_resume_early(struct device *dev)
+static int lpss_resume_early(struct device *dev)
{
struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));
int ret;
@@ -746,6 +752,17 @@ static int acpi_lpss_resume_early(struct device *dev)
if (pdata->dev_desc->flags & LPSS_SAVE_CTX)
acpi_lpss_restore_ctx(dev, pdata);
+ return 0;
+}
+
+static int acpi_lpss_resume_early(struct device *dev)
+{
+ int ret;
+
+ ret = lpss_resume_early(dev);
+ if (ret)
+ return ret;
+
return pm_generic_resume_early(dev);
}
#endif /* CONFIG_PM_SLEEP */
--
2.7.4
More information about the linux-arm-kernel
mailing list