[PATCH] mt7601u: check memory allocation failure
Jakub Kicinski
kubakici at wp.pl
Mon Aug 21 14:41:36 PDT 2017
On Mon, 21 Aug 2017 14:34:30 -0700, Jakub Kicinski wrote:
> On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote:
> > Check memory allocation failure and return -ENOMEM in such a case, as
> > already done a few lines below
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
>
> Acked-by: Jakub Kicinski <kubakici at wp.pl>
Wait, I take that back. This code is a bit weird. We would return an
error, then mt7601u_dma_init() will call mt7601u_free_tx_queue() which
doesn't check for tx_q == NULL condition.
Looks like mt7601u_free_tx() has to check for dev->tx_q == NULL and
return early if that's the case. Or mt7601u_alloc_tx() should really
clean things up on it's own on failure. Ugh.
More information about the linux-arm-kernel
mailing list