[PATCH] irqchip/armada-370-xp: Enable MSI-X support

[Stefan Roese]

Hi Thomas,

On 15.08.2017 16:06, Stefan Roese wrote:
> On 15.08.2017 16:01, Thomas Petazzoni wrote:
>> On Tue, 15 Aug 2017 15:31:31 +0200, Stefan Roese wrote:
>>
>>> On 02.05.2017 09:26, Stefan Roese wrote:
>>>> Armada XP does not only support MSI, but also MSI-X. This patch sets
>>>> the MSI_FLAG_PCI_MSIX flag in the interrupt controller driver which
>>>> is the only change necessary to enable MSI-X support on this SoC. As
>>>> the Linux PCI MSI-X infrastructure takes care of writing the data and
>>>> address structures into the BAR specified by the MSI-X controller.
>>>>
>>>> Signed-off-by: Stefan Roese <sr at denx.de>
>>>> Cc: Bjorn Helgaas <bhelgaas at google.com>
>>>> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
>>>> Cc: Gregory CLEMENT <gregory.clement at free-electrons.com>
>>>> Cc: Jason Cooper <jason at lakedaemon.net>
>>>> Cc: Thomas Gleixner <tglx at linutronix.de>
>>>> ---
>>>>    drivers/irqchip/irq-armada-370-xp.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/irqchip/irq-armada-370-xp.c 
>>>> b/drivers/irqchip/irq-armada-370-xp.c
>>>> index 33982cbd8a57..b17039ed8735 100644
>>>> --- a/drivers/irqchip/irq-armada-370-xp.c
>>>> +++ b/drivers/irqchip/irq-armada-370-xp.c
>>>> @@ -124,7 +124,7 @@ static struct irq_chip 
>>>> armada_370_xp_msi_irq_chip = {
>>>>    static struct msi_domain_info armada_370_xp_msi_domain_info = {
>>>>        .flags    = (MSI_FLAG_USE_DEF_DOM_OPS | 
>>>> MSI_FLAG_USE_DEF_CHIP_OPS |
>>>> -           MSI_FLAG_MULTI_PCI_MSI),
>>>> +           MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX),
>>>>        .chip    = &armada_370_xp_msi_irq_chip,
>>>>    };
>>>
>>> Its been a while since this patch has been submitted - without any
>>> comments so far. What's the current status with it? Is it someones
>>> queue for upstreaming?
>>
>> Sorry for the lack of feedback, very good idea to ping me on this
>> topic. I don't have access to HW right now, so I can't give it a test.
>> However, I don't think I have MSI-X capable hardware, only MSI capable.
>>
>> With which hardware did you test this? An off-the-shell PCIe card, or
>> some custom FPGA logic?
> 
> I tested this code with some Altera / Intel FPGA using their PCI-Express
> IP core. It should be possible to test this with some MSI-X capable
> desktop PCIe cards as well on AXP boards equipped with PCIe slots,
> like the Marvell AXP development board (orange box).

So what do you think about this patch? Can I get your Acked-by /
Reviewed-by, or do you have some objections? Or do plan to first do
some tests yourself?

Thanks,
Stefan