[PATCH] irqchip/gic-v3-its-platform-msi: Fix msi-parent parsing loop

Marc Zyngier marc.zyngier at arm.com
Thu Aug 10 08:28:41 PDT 2017


On 10/08/17 15:41, Lorenzo Pieralisi wrote:
> While parsing the msi-parent property to chase up the IRQ domain
> a given device belongs to, the index into the msi-parent tuple should
> be incremented to ensure all properties entries are taken into account.
> 
> Current code missed the index update so the parsing loop does not work
> in case multiple msi-parent phandles are present and may turn into
> an infinite loop in of_pmsi_get_dev_id() if phandle at index 0 does
> not correspond to the domain we are actually looking-up.
> 
> Fix the code by updating the phandle index at each iteration in
> of_pmsi_get_dev_id().
> 
> Fixes: deac7fc1c87f ("irqchip/gic-v3-its: Parse new version of msi-parent property")
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>
> Cc: Marc Zyngier <marc.zyngier at arm.com>
> ---
> Marc,
> 
> nothing urgent, I have just bumped into it while checking how ITS
> DeviceIDs are handled in DT.

Duh. Nice catch. Applied to the next batch of fixes (waiting for tglx to
resurface...).

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...



More information about the linux-arm-kernel mailing list