[PATCH] pinctrl: sirf: atlas7: fix of_irq_get() error check

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Fri Aug 4 09:58:51 PDT 2017


On 08/04/2017 12:31 AM, Linus Walleij wrote:

>> of_irq_get() may return  any negative error number as well as 0 on failure,
>> while the driver only checks for -EPROBE_DEFER, blithely continuing with
>> the call to gpiochip_set_chained_irqchip() -- that function expects the
>> parent IRQ as *unsigned int*, so would probably do nothing  when a large
>> IRQ number resulting from a conversion of a negative error number is passed
>> to it, however passing 0 would probably work but the driver won't receive
>> valid GPIO bank interrupts.
>>
>> Check for 'ret <= 0' instead and return -ENXIO from the driver's probe iff
>> of_irq_get() returned 0.
>>
>> Fixes: f9367793293d ("pinctrl: sirf: add sirf atlas7 pinctrl and gpio support")
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
> 
> Patch applied!

   Thanks! But to which branch? I'm not seeing it in linux-pinctrl.git...

> Yours,
> Linus Walleij

MBR, Sergei



More information about the linux-arm-kernel mailing list