[PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

[Hans Verkuil]

On 08/02/2017 12:32 AM, Laurent Pinchart wrote:
>> +
>> +	cec_register_cec_notifier(cec->adap, cec->notify);
>> +
>> +	return 0;
>> +}
>> +
>> +static int dw_hdmi_cec_remove(struct platform_device *pdev)
>> +{
>> +	struct dw_hdmi_cec *cec = platform_get_drvdata(pdev);
>> +
>> +	cec_unregister_adapter(cec->adap);
>> +	cec_notifier_put(cec->notify);
>> +
>> +	return 0;
>> +}
>> +
>> +static struct platform_driver dw_hdmi_cec_driver = {
>> +	.probe	= dw_hdmi_cec_probe,
>> +	.remove	= dw_hdmi_cec_remove,
>> +	.driver = {
>> +		.name = "dw-hdmi-cec",
>> +	},
>> +};
>> +module_platform_driver(dw_hdmi_cec_driver);
> 
> Is there a particular reason why this has to be a separate module instead of 
> simply calling the CEC init/cleanup functions directly from the main dw-hdmi 
> driver ?

Not all SoCs that use dw-hdmi also use the dw-hdmi CEC implementation. Some
use their own implementation (amlogic). So by implementing the cec-notifier in
the dw-hdmi driver and keeping dw-hdmi CEC separate you can easily choose
whether or not you want to use this CEC driver or another SoC CEC driver.

Regards,

	Hans

> 
>> +MODULE_AUTHOR("Russell King <rmk+kernel at armlinux.org.uk>");
>> +MODULE_DESCRIPTION("Synopsys Designware HDMI CEC driver for i.MX");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS(PLATFORM_MODULE_PREFIX "dw-hdmi-cec");
>