[PATCH v5 0/2] iommu/smmu-v3: Workaround for hisilicon 161010801 erratum(reserve HW MSI)
Shameer Kolothum
shameerali.kolothum.thodi at huawei.com
Tue Aug 1 03:49:11 PDT 2017
On certain HiSilicon platforms (Hip06/Hip07) the GIC ITS and
PCIe RC deviates from the standard implementation and this breaks
PCIe MSI functionality when SMMU is enabled.
The HiSilicon erratum 161010801 describes this limitation of certain
HiSilicon platforms to support the SMMU mappings for MSI transactions.
On these platforms GICv3 ITS translator is presented with the deviceID
by extending the MSI payload data to 64 bits to include the deviceID.
Hence, the PCIe controller on this platforms has to differentiate the
MSI payload against other DMA payload and has to modify the MSI payload.
This basically makes it difficult for this platforms to have a SMMU
translation for MSI.
To implement this quirk, the following changes are incorporated:
1. Added a generic helper function to IORT code to retrieve and
reserve the HW ITS address regions.
2. Modified iommu_dma_get_resv_regions() to reserve the hw msi
regions which means these address regions will not be translated and
will be excluded from iova allocations.
Note: This requires patches [1] and [2] for vfio pass-through support
on these platforms.
Thanks,
Shameer
[1]: https://lkml.org/lkml/2017/7/27/388
[2]: https://lkml.org/lkml/2017/7/27/386
Changelog:
v4 --> v5
Addressed comments from Robin and Lorenzo:
-Added a comment to make it clear that, for now, only straightforward
HW topologies are handled while reserving ITS regions(patch #1).
v3 --> v4
Rebased on 4.13-rc1.
Addressed comments from Robin, Will and Lorenzo:
-As suggested by Robin, moved the ITS msi reservation into
iommu_dma_get_resv_regions().
-Added its_count != resv region failure case(patch #1).
v2 --> v3
Addressed comments from Lorenzo and Robin:
-Removed dev_is_pci() check in smmuV3 driver.
-Don't treat device not having an ITS mapping as an error in
iort helper function.
v1 --> v2
-patch 2/2: Invoke iort helper fn based on fwnode type(acpi).
RFCv2 -->PATCH
-Incorporated Lorenzo's review comments.
RFC v1 --> RFC v2
Based on Robin's review comments,
-Removed the generic erratum framework.
-Using IORT/MADT tables to retrieve the ITS base addr instead
of vendor specific CSRT table.
Shameer Kolothum (2):
ACPI/IORT: Add ITS address regions reservation helper
iommu/dma: Add HW MSI address regions reservation
drivers/acpi/arm64/iort.c | 95 ++++++++++++++++++++++++++++++++++++++--
drivers/iommu/dma-iommu.c | 8 +++-
drivers/irqchip/irq-gic-v3-its.c | 3 +-
include/linux/acpi_iort.h | 7 ++-
4 files changed, 107 insertions(+), 6 deletions(-)
--
1.9.1
More information about the linux-arm-kernel
mailing list