[PATCH v3] efifb: avoid reconfiguration of BAR that covers the framebuffer

Yinghai Lu yinghai at kernel.org
Fri Apr 28 13:51:54 PDT 2017


On Thu, Apr 27, 2017 at 6:55 AM, Ard Biesheuvel
<ard.biesheuvel at linaro.org> wrote:
> On 23 April 2017 at 02:45, Yinghai Lu <yinghai at kernel.org> wrote:

>>
>> looks like those two lines are reversed. you should use:
>>                 pcibios_resource_survey_bus(bus);
>>                 pci_assign_unassigned_root_bus_resources(bus);
>>
>> please check x86 pcibios_resource_survey_bus() definition in
>>         arch/x86/pci/i386.c
>>
>> but pci_bus_claim_resources() should work too.
>>
>
> pcibios_resource_survey_bus() is actually an empty function on arm64,
> but I guess that is where logic should go that checks the state of the
> BARs before trying to claim anything?

Yes. Please copy for x86 and simplify it for arm64.

Yinghai



More information about the linux-arm-kernel mailing list