[PATCH v2 02/30] pinctrl: mediatek: reuse pinctrl driver for mt7623

Linus Walleij linus.walleij at linaro.org
Fri Apr 28 04:01:52 EDT 2017


On Wed, Apr 26, 2017 at 11:25 AM,  <sean.wang at mediatek.com> wrote:

> From: Sean Wang <sean.wang at mediatek.com>
>
> mt7623 pinctrl driver can be compatible with mt2701 one,
> so the patch reuses the driver and deletes those redundant
> ones.
>
> Cc: John Crispin <john at phrozen.org>
> Signed-off-by: Sean Wang <sean.wang at mediatek.com>

Partly correct.

>         "mediatek,mt6397-pinctrl", compatible with mt6397 pinctrl.
> -       "mediatek,mt7623-pinctrl", compatible with mt7623 pinctrl.

NO don't do this.

"compatible" means exactly this: this hardware is compatible with
this driver. That is why we have it!

So instead of mt7623 pretending to be mt2701, let the mt2701 driver
list that it is compatible with mt7623, simple.

So patch pinctrl-mt2701.c mt2701_pctrl_match[] instead.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list