[PATCH 2/2] arm64:vdso: Remove ISB from gettimeofday.
apinski at cavium.com
Sun Apr 23 19:47:01 EDT 2017
ISB is normally required before mrs CNTVCT if we want the
mrs to completed after the loads. In this case it is not.
As we are taking the difference and if that difference
was going to be negative, we just use the last counter value
Signed-off-by: Andrew Pinski <apinski at cavium.com>
arch/arm64/kernel/vdso/gettimeofday.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/vdso/gettimeofday.c b/arch/arm64/kernel/vdso/gettimeofday.c
index a0ab8b1..cf3235a 100644
@@ -117,10 +117,20 @@ static notrace u64 get_clock_shifted_nsec(u64 cycle_last, u64 mult)
/* Read the virtual counter. */
+ * This normally requires an ISB but since we know the
+ * read of the last cycle will always be after the
+ * read of the values are valid word.
asm volatile("mrs %0, cntvct_el0" : "=r" (res) :: "memory");
- res = res - cycle_last;
+ * If the current cycle is greater than the last,
+ * then get the difference.
+ if (res > cycle_last)
+ res = res - cycle_last;
/* We can only guarantee 56 bits of precision. */
res &= ~(0xff00ul<<48);
return res * mult;
More information about the linux-arm-kernel