[PATCH V3] PM / OPP: Use - instead of @ for DT entries

Olof Johansson olof at lixom.net
Wed Apr 19 10:22:15 EDT 2017


Hi Viresh,

On Tue, Apr 18, 2017 at 10:44:50AM +0530, Viresh Kumar wrote:
> Compiling the DT file with W=1, DTC warns like follows:
> 
> Warning (unit_address_vs_reg): Node /opp_table0/opp at 1000000000 has a
> unit name, but no reg property
> 
> Fix this by replacing '@' with '-' as the OPP nodes will never have a
> "reg" property.
> 
> Reported-by: Krzysztof Kozlowski <krzk at kernel.org>
> Reported-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> Suggested-by: Mark Rutland <mark.rutland at arm.com>
> Signed-off-by: Viresh Kumar <viresh.kumar at linaro.org>
> Acked-by: Maxime Ripard <maxime.ripard at free-electrons.com> (sunxi)
> Reviewed-by: Chanwoo Choi <cw00.choi at samsung.com>
> Reviewed-by: Krzysztof Kozlowski <krzk at kernel.org>
> Acked-by: Masahiro Yamada <yamada.masahiro at socionext.com> (uniphier)
> Acked-by: Rob Herring <robh at kernel.org>
> Acked-by: Tony Lindgren <tony at atomide.com>

We've already turned down other patches that does this in a sweeping manner
like this, since they tend to be conflict prone with other DT changes.

Please split per platform and merge with each maintainer.


Thanks,

-Olof




More information about the linux-arm-kernel mailing list