[PATCH] ARM: Fix rd_size declaration

Bart Van Assche Bart.VanAssche at sandisk.com
Tue Apr 18 10:07:53 EDT 2017


On Tue, 2017-04-18 at 09:35 +0200, Johannes Thumshirn wrote:
> On Mon, Apr 17, 2017 at 04:10:03PM -0700, Bart Van Assche wrote:
> > The global variable 'rd_size' is declared as 'int' in source file
> > arch/arm/kernel/atags_parse.c and as 'unsigned long' in
> > drivers/block/brd.c. Fix this inconsistency.
> > 
> > Signed-off-by: Bart Van Assche <bart.vanassche at sandisk.com>
> > Cc: Russell King <linux at armlinux.org.uk>
> > Cc: Jens Axboe <axboe at kernel.dk>
> > Cc: Jan Kara <jack at suse.cz>
> > Cc: <yanaijie at huawei.com>
> > Cc: <zhaohongjiang at huawei.com>
> > Cc: <miaoxie at huawei.com>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Cc: linux-block at vger.kernel.org
> > ---
> > diff --git a/include/linux/brd.h b/include/linux/brd.h
> > new file mode 100644
> > index 000000000000..dbb0f92fefc8
> > --- /dev/null
> > +++ b/include/linux/brd.h
> > @@ -0,0 +1 @@
> > +extern unsigned long rd_size;
> 
> Small nit, can you add an include guard here as well?

Hello Johannes,

Thanks for the review. But are you aware that with the current content an
include guard is overkill because it is safe to evaluate the "extern unsigned
long rd_size" declaration multiple times?

Bart.


More information about the linux-arm-kernel mailing list