[PATCH V2] PM / OPP: Use - instead of @ for DT entries

Rafael J. Wysocki rjw at rjwysocki.net
Mon Apr 17 12:40:08 EDT 2017


On Monday, April 17, 2017 06:35:25 PM Rafael J. Wysocki wrote:
> On Monday, April 17, 2017 11:07:51 AM Masahiro Yamada wrote:
> > 2017-04-15 7:47 GMT+09:00 Rafael J. Wysocki <rjw at rjwysocki.net>:
> > > On Monday, April 10, 2017 02:51:35 PM Viresh Kumar wrote:
> > >> Compiling the DT file with W=1, DTC warns like follows:
> > >>
> > >> Warning (unit_address_vs_reg): Node /opp_table0/opp at 1000000000 has a
> > >> unit name, but no reg property
> > >>
> > >> Fix this by replacing '@' with '-' as the OPP nodes will never have a
> > >> "reg" property.
> > >>
> > >> Reported-by: Krzysztof Kozlowski <krzk at kernel.org>
> > >> Reported-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> > >> Suggested-by: Mark Rutland <mark.rutland at arm.com>
> > >> Signed-off-by: Viresh Kumar <viresh.kumar at linaro.org>
> > >> Acked-by: Maxime Ripard <maxime.ripard at free-electrons.com> (sunxi)
> > >> Reviewed-by: Chanwoo Choi <cw00.choi at samsung.com>
> > >> Reviewed-by: Krzysztof Kozlowski <krzk at kernel.org>
> > >
> > > OK, so any ACKs from the DT side?  Rob?
> > >
> > > Thanks,
> > > Rafael
> > 
> > 
> > 
> > I see Rob's Acked-by.
> > 
> > https://lkml.org/lkml/2017/4/13/648
> 
> Indeed.  Thanks!

But it doesn't apply on top of -rc7 for me, so I guess there is new 4.12-candidate
material in the DTS tree that conflicts with this, in which case it is better to route
it through the DTS tree IMO.

Thanks,
Rafael




More information about the linux-arm-kernel mailing list