[PATCH] fs: seq_buf_alloc use vmalloc for high order allocations
Chunhui Li
chunhui.li at mediatek.com
Tue Apr 4 18:29:04 PDT 2017
From: "chunhui.li" <chunhui.li at mediatek.com>
For high order allocations, use vmalloc() to reduce physically
contiguous memory consumption and avoid memory fragmentation issues
Signed-off-by: chunhui.li <chunhui.li at mediatek.com>
---
fs/seq_file.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/fs/seq_file.c b/fs/seq_file.c
index ca69fb9..4527e79 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -26,19 +26,17 @@ static void seq_set_overflow(struct seq_file *m)
static void *seq_buf_alloc(unsigned long size)
{
void *buf;
- gfp_t gfp = GFP_KERNEL;
/*
- * For high order allocations, use __GFP_NORETRY to avoid oom-killing -
- * it's better to fall back to vmalloc() than to kill things. For small
- * allocations, just use GFP_KERNEL which will oom kill, thus no need
- * for vmalloc fallback.
- */
+ * For high order allocations, use vmalloc() to reduce physically
+ * contiguous memory usage and avoid memory fragmentation issue.
+ * For small allocations, just use GFP_KERNEL
+ * which will oom kill, thus no need for vmalloc fallback.
+ */
if (size > PAGE_SIZE)
- gfp |= __GFP_NORETRY | __GFP_NOWARN;
- buf = kmalloc(size, gfp);
- if (!buf && size > PAGE_SIZE)
buf = vmalloc(size);
+ else
+ buf = kmalloc(size, GFP_KERNEL);
return buf;
}
--
2.9.2
More information about the linux-arm-kernel
mailing list