[PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel
ard.biesheuvel at linaro.org
Tue Apr 4 00:39:28 PDT 2017
On 4 April 2017 at 08:35, AKASHI Takahiro <takahiro.akashi at linaro.org> wrote:
> On Tue, Apr 04, 2017 at 06:14:55AM -0000, David Woodhouse wrote:
>> > On Mon, Apr 03, 2017 at 09:18:12AM +0100, David Woodhouse wrote:
>> >> You still have typos here.
>> > I'd like to defer to the maintainers whether we prefer MiB over MB.
>> It is not really a matter of preference. One is correct; the other is not.
>> While simple errors can of course be forgiven, I cannot understand why you
>> would deliberately repeat an error once it has been pointed out to you.
> Because I think that people sometimes use those two interchangeably.
> So I said I would defer to the maintainers.
I have to agree with Akashi-san here: while you are technically
correct, the reality is that the MiB is not as widely adopted as you
suggest, and there is no ambiguity whatsoever in this particular case
(i.e., when referring to blocks of RAM), so I feel it is somewhat
counterproductive to confuse reviewers by stating 'You still have
typos here.' without specifying that it is MiB vs MB that you are
actually referring to.
These patches are complex enough as they are, so could we *please*
focus on the things that matter?
More information about the linux-arm-kernel