[linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC

[Leo Li]

> -----Original Message-----
> From: linux-devel-bounces at gforge.freescale.net [mailto:linux-devel-
> bounces at gforge.freescale.net] On Behalf Of Bhaskar U
> Sent: Friday, September 30, 2016 4:19 PM
> To: Stuart Yoder <stuart.yoder at nxp.com>; devicetree at vger.kernel.org;
> shawnguo at kernel.org
> Cc: oss at buserror.net; linux-devel at gforge.freescale.net; Pratiyush Srivastava
> <pratiyush.srivastava at nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; linux-arm-kernel at lists.infradead.org
> Subject: Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's
> LS1012A SoC
> 
> 
> 
> >-----Original Message-----
> >From: Stuart Yoder
> >Sent: Friday, September 30, 2016 7:28 PM
> >To: Bhaskar U <bhaskar.upadhaya at nxp.com>; devicetree at vger.kernel.org;
> >shawnguo at kernel.org
> >Cc: oss at buserror.net; linux-arm-kernel at lists.infradead.org; linux-
> >devel at gforge.freescale.net; Bhaskar U <bhaskar.upadhaya at nxp.com>;
> >Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; Pratiyush Srivastava
> ><pratiyush.srivastava at nxp.com>
> >Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A
> >SoC
> >
> >> +		dspi0: dspi at 2100000 {
> >> +			compatible = "fsl,ls1012a-dspi",
> >> +				     "fsl,ls1043a-dspi",
> >> +				     "fsl,ls1021a-v1.0-dspi";
> >> +			#address-cells = <1>;
> >> +			#size-cells = <0>;
> >> +			reg = <0x0 0x2100000 0x0 0x10000>;
> >> +			interrupts = <0 64 0x4>;
> >> +			clock-names = "dspi";
> >> +			clocks = <&clockgen 4 0>;
> >> +			spi-num-chipselects = <5>;
> >> +			big-endian;
> >> +			status = "enabled";
> >
> >"enabled" is not a valid status value.
> >
> 
> So shall I put the status = "okay" ?
> 
> But there are other nodes like i2c below having status = "enabled", so do we
> need to edit them also ? If yes then what should be written in the status ?
> i2c0: i2c at 2180000 {
>                         compatible = "fsl,vf610-i2c";
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>                         reg = <0x0 0x2180000 0x0 0x10000>;
>                         interrupts = <0 56 0x4>;
>                         clock-names = "i2c";
>                         clocks = <&clockgen 4 0>;
>                         status = "enabled";
>                 };
> 
>                 i2c1: i2c at 2190000 {
>                         compatible = "fsl,vf610-i2c";
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>                         reg = <0x0 0x2190000 0x0 0x10000>;
>                         interrupts = <0 57 0x4>;
>                         clock-names = "i2c";
>                         clocks = <&clockgen 4 0>;
>                         status = "enabled";
>                 };

The default is "okay".  You should just remove these status properties.

Regards,
Leo