[PATCH] tty: amba-pl011: uart_amba_port is not available with earlycon function

Shawn Guo shawnguo at kernel.org
Tue Sep 20 06:05:04 PDT 2016


On Sat, Sep 17, 2016 at 02:14:38PM +0800, Shawn Guo wrote:
> Commit 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE
> device") changes earlycon function pl011_putc() to use a pointer to
> uart_amba_port.  This causes a regression when earlycon is enabled,
> because uart_amba_port is not available yet at earlycon time.  Let's
> revert the change on pl011_putc() to fix the regression.
> 
> The earlycon support for ZTE device can probably be added later by
> declaring a new earlycon setup function with a vendor specific
> compatible.
> 
> Reported-by: Sudeep Holla <sudeep.holla at arm.com>
> Fixes: 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE device")
> Signed-off-by: Shawn Guo <shawn.guo at linaro.org>

Hi Sudeep,

Can you please confirm if the patch fixes your problem, so that Greg
knows whether it should be applied?  Thanks.

Shawn



More information about the linux-arm-kernel mailing list