[PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices

Sylwester Nawrocki s.nawrocki at samsung.com
Thu Sep 15 02:05:12 PDT 2016


On 09/14/2016 08:29 PM, Sam Van Den Berge wrote:
> +static const struct dma_slave_map s3c2440_dma_slave_map[] = {
...
> +	{ "3c2440-sdi", "rx", (void *)DMACH_SDI },
> +	{ "3c2440-sdi", "tx", (void *)DMACH_SDI },

The device names seem misspelled here, and looking at what
drivers/mmc/host/s3cmci.c driver does we need just a single common
entry for rx and tx

	{ "s3c2440-sdi", "rx-tx", (void *)DMACH_SDI },

With this fixed feel free to add

Reviewed-by: Sylwester Nawrocki <s.nawrocki at samsung.com>

-- 
Thanks,
Sylwester



More information about the linux-arm-kernel mailing list