[PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X

Carlo Caione carlo at caione.org
Mon Sep 12 23:14:36 PDT 2016


On Mon, Sep 12, 2016 at 11:43 PM, Andreas Färber <afaerber at suse.de> wrote:

[cut]
> I'm not arguing over the file name, where it perfectly makes sense to
> have a meson-gxl- prefix (already discussed), just about the compatible
> string where we don't have "amlogic,meson-gxl-s905x-p231" either because
> it is completely unnecessary and does _not_ add any value.
>
> Not that we're checking this string anywhere anyway... If you want to
> check for the GXL family you have to use "amlogic,meson-gxl"; if you
> want to check for the specific SoC you use "amlogic,s905x". Simple. We
> never match partial strings, so there is no sense in a hardcoded prefix
> that is duplicating information already available.

Ok, then. Fine with me.

Neil, do you want to resend my patch or you can take care of the fixes
for the whole patchset?

Thanks,

-- 
Carlo Caione



More information about the linux-arm-kernel mailing list