[PATCH] ARM: imx35: add iim module to imx35.dtsi

Fabio Estevam festevam at gmail.com
Thu Sep 8 11:09:17 PDT 2016


On Thu, Sep 8, 2016 at 2:55 PM, Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:

>> Where is "fsl,imx35-iim" defined?
>
> right next to the other fsl,imx*-iim :-)

Ok,  "fsl,imx35-iim" is not being used arch/arm/mach-imx/cpu-imx35.c currently.

I suppose you want to replace
 "rev = imx_readl(MX35_IO_ADDRESS(MX35_IIM_BASE_ADDR + MXC_IIMSREV));"

by retrieving the base address via dt, like we do in
imx5_read_srev_reg() at arch/arm/mach-imx/cpu-imx5.c.


> By the way, compared to the other imx*.dtsi I didn't declare
> compatibility to fsl,imx27-iim. I checked the i.MX25 reference manual
> and the i.MX35 looked different. Didn't check for imx5x and the i.MX27
> RM doesn't describe the registers. What do you think?

I think this is fine as is, so:

Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>



More information about the linux-arm-kernel mailing list