[PATCH] ARM: dts: exynos: Add entries for sound support on Odroid-XU board

Sylwester Nawrocki s.nawrocki at samsung.com
Tue Sep 6 04:30:12 PDT 2016


On 08/30/2016 08:42 AM, Krzysztof Kozlowski wrote:
>> +&clock {
>> > +       clocks = <&fin_pll>;
> I dig into it and I have some questions:
> 1. Missing clock-names?
> 2. What code parses it?
> 3. Don't we need it also for other SoC/boards?

Apologies, I missed this one.

Ad.1. clock-names is not needed as there will be only one clock and there
is no need to get the clock by name.  If it bothers you we could add e.g.
clock-names = "osc", but IMO it's just an unnecessary complication.

Ad.2 of_clk_get() called from within of_clk_init() and exynos5410_clk_init.

Ad.2. I think it makes sense to add it for all Exynos SoCs where it's missing.

-- 
Regards,
Sylwester



More information about the linux-arm-kernel mailing list