[PATCH v3 10/22] usb: chipidea: Consolidate extcon notifiers

Stephen Boyd stephen.boyd at linaro.org
Fri Sep 2 18:03:06 PDT 2016


On Thu, Sep 1, 2016 at 8:17 PM, Peter Chen <hzpeterchen at gmail.com> wrote:
> On Wed, Aug 31, 2016 at 05:40:24PM -0700, Stephen Boyd wrote:
>>
>>
>>               if (cable->state)
>> -                     val |= OTGSC_ID;
>> +                     val &= ~OTGSC_ID; /* A device */
>>               else
>> -                     val &= ~OTGSC_ID;
>> +                     val |= OTGSC_ID; /* B device */
>>
>>               if (cable->enabled)
>>                       val |= OTGSC_IDIE;
>
> /**
>  * struct ci_hdrc_cable - structure for external connector cable state tracking
>  * @state: current state of the line
>
> You may change the name of variable "state" to "connected", per I
> understand, it has changed to the meaning of connected status for your patch.
>

Ok sure.



More information about the linux-arm-kernel mailing list