irq_create_fwspec_mapping() in 4.8-rc2

Marc Zyngier marc.zyngier at arm.com
Fri Sep 2 08:09:19 PDT 2016


On 02/09/16 15:52, Andras Szemzo wrote:
>>
>> Can you try this patch and report the values you find?
>>
> Sure, here is the output:
> 
> irq: type mismatch (2/3), failed to map hwirq-11 for /soc/pinctrl at 0x400e0e00/gpio at 0x400e1200!

So something has already configured the interrupt to be
IRQ_TYPE_EDGE_BOTH, and this clashes with your
IRQ_TYPE_EDGE_FALLING.

My bet is on this one:

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 80daead..9f09041 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
 				   &gpio_irqchip,
 				   0,
 				   handle_edge_irq,
-				   IRQ_TYPE_EDGE_BOTH);
+				   IRQ_TYPE_NONE);
 	if (ret) {
 		dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",
 			at91_gpio->pioc_idx);

Can you give it a go and let me know what happens?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...



More information about the linux-arm-kernel mailing list