[PATCH 1/6] pinctrl: dt-bindings: samsung: Update documentation with new macros
Javier Martinez Canillas
javier at osg.samsung.com
Thu Sep 1 03:29:50 PDT 2016
Hello Krzysztof,
On 09/01/2016 11:21 AM, Krzysztof Kozlowski wrote:
> Update examples in Samsung pinctrl dt-bindings with new macros coming
> from header file.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> ---
> .../bindings/pinctrl/samsung-pinctrl.txt | 42 +++++++++++-----------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> index 6db16b90873a..828ef7fdd437 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> @@ -238,53 +238,53 @@ Example 1: A pin-controller node with pin groups.
>
> uart0_data: uart0-data {
> samsung,pins = "gpa0-0", "gpa0-1";
> - samsung,pin-function = <2>;
> - samsung,pin-pud = <0>;
> - samsung,pin-drv = <0>;
> + samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> };
I wonder if besides updating the examples, the DT binding shouldn't also
mention include/dt-bindings/pinctrl/samsung.h and list the macros for each
possible pin configuration.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
More information about the linux-arm-kernel
mailing list