ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

SF Markus Elfring elfring at users.sourceforge.net
Mon Oct 17 04:30:59 PDT 2016


>> Some data were printed into a sequence by six separate function calls.
>> Print the same data by a single function call instead.
> 
> ... why?
> 
> Beyond simply having fewer function calls, is there an upside?

Will it matter to improve run time characteristics at this source code place?


> This makes it harder to see the relationship between the format strings
> and their associated data, and makes the code longer.

Do you prefer an other layout for the passed data so that the increase
of line count in my update suggestion would look differently?

Regards,
Markus



More information about the linux-arm-kernel mailing list