[PATCH v3 1/2] clk: imx: fix integer overflow in AV PLL round rate

Fabio Estevam festevam at gmail.com
Fri Oct 14 06:33:43 PDT 2016


On Wed, Oct 12, 2016 at 7:31 AM, Emil Lundmark <emil at limesaudio.com> wrote:
> Since 'parent_rate * mfn' may overflow 32 bits, the result should be
> stored using 64 bits.
>
> The problem was discovered when trying to set the rate of the audio PLL
> (pll4_post_div) on an i.MX6Q. The desired rate was 196.608 MHz, but
> the actual rate returned was 192.000570 MHz. The round rate function should
> have been able to return 196.608 MHz, i.e., the desired rate.
>
> Fixes: ba7f4f557eb6 ("clk: imx: correct AV PLL rate formula")
> Cc: Anson Huang <b20788 at freescale.com>
> Signed-off-by: Emil Lundmark <emil at limesaudio.com>

Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>



More information about the linux-arm-kernel mailing list