[PATCH] arm64: mmu: set the contiguous for kernel mappings when appropriate

[Mark Rutland]

On Tue, Oct 11, 2016 at 08:44:19AM +0100, Mark Rutland wrote:
> >  {
> > +	pgprot_t prot_cont = __pgprot(pgprot_val(prot) | PTE_CONT);
> > +	bool cont = false;
> >  	pte_t *pte;
> >  
> >  	BUG_ON(pmd_sect(*pmd));
> > @@ -115,7 +118,20 @@ static void alloc_init_pte(pmd_t *pmd, unsigned long addr,
> >  
> >  	pte = pte_set_fixmap_offset(pmd, addr);
> >  	do {
> > -		set_pte(pte, pfn_pte(pfn, prot));
> > +		/*
> > +		 * Set the contiguous bit for the subsequent group of PTEs if
> > +		 * its size and alignment are suitable.
> > +		 */
> > +		if (((addr | PFN_PHYS(pfn)) & ~CONT_MASK) == 0)
> > +			cont = allow_block_mappings && end - addr >= CONT_SIZE;
> 
> Given we increment addr by PAGE_SIZE in the loop, isn't this only true for the
> first CONT_SIZE aligned entry, and not its (intended-to-be-contiguous)
> siblings?

Looking again, I'd mis-read the above; it will work as expected.

Sorry for the noise.

Thanks,
Mark.