[linux-sunxi] Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3
Icenowy Zheng
icenowy at aosc.xyz
Wed Nov 30 18:02:59 PST 2016
01.12.2016, 04:52, "Maxime Ripard" <maxime.ripard at free-electrons.com>:
> On Wed, Nov 30, 2016 at 09:41:26PM +0100, Jernej Škrabec wrote:
>> > > > > The only
>> > > > > code left from you is for DE2. HDMI stuff is basically copied from
>> > > > > Rockhip
>> > > > > driver (including EDID reading), TCON code is now reverted to the same
>> > > > > as
>> > > > > it is in sunxi_display.c. I think it is worth to take a look at EDID
>> > > > > code
>> > > > > and compare it.
>> > > >
>> > > > So is the TCON of DE 2.0 identical to the original TCON?
>> > > >
>> > > > If so, we should reuse sun4i-tcon ...
>> > >
>> > > Well, TCON is splitted in two parts (two base addresses), one for HDMI and
>> > > one for TV. However, register offsets are same as before, so I guess
>> > > driver reusage make sense. I think that there are few additional
>> > > registers, but they can be ignored for simplefb.
>> >
>> > The TCON1 of the H3 is not usable (no ckock). Analog TV has its own
>> > clock and I/O area.
>> >
>>
>> True, H3 user manual can be misleading sometimes. But this doesn't change the
>> fact that TCON0 has same register offsets with same meaning.
>
> Then yes, we should definitely share the drivers too. So, in the end,
> the only thing that is actually new is the display-engine?
And HDMI PHY on H3 ;-)
In my opinion, we should just put sun8i-de2-drm related code into drivers/gpu/drm/sun4i/ .
(Or rename the directory to sunxi)
>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
More information about the linux-arm-kernel
mailing list