[PATCH] coresight: perf: Add a missing call to etm_free_aux

Quentin Lambert lambert.quentin at gmail.com
Sat Nov 19 10:22:21 PST 2016


On 11/19/2016 06:41 PM, Quentin Lambert wrote:
> Most error branches following the call to alloc_event_data contain a call to
> etm_free_aux. This patch add a call to etm_free_aux to an error branch
> that does not call it.
>
> This issue was found with Hector.
>
> Signed-off-by: Quentin Lambert <lambert.quentin at gmail.com>
> ---
>   drivers/hwtracing/coresight/coresight-etm-perf.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -215,7 +215,7 @@ static void *etm_setup_aux(int event_cpu
>   	 */
>   	sink = coresight_get_enabled_sink(true);
>   	if (!sink)
> -		return NULL;
> +		goto err;
>   
>   	INIT_WORK(&event_data->work, free_event_data);
>   
I realized that I hadn't try to compile after having sent this patch and
I wasn't able to compile it.
Therefore, please ignore it for now.

Quentin



More information about the linux-arm-kernel mailing list