[PATCH v3 06/13] ARM: dts: armada-375: Fixup sa-ram DT warning
thomas.petazzoni at free-electrons.com
Fri Nov 18 05:35:51 PST 2016
On Fri, 18 Nov 2016 13:06:17 +0100, Gregory CLEMENT wrote:
> > But do we really want this comment above each node? Couldn't we instead
> > add this explanation in the mvebu-mbus.txt DT binding?
> We could but I fear that nobody will read it.
> Indeed if you know that in order to understand the unit address, you will
> have to have a look an the binding of the mvebu-mbus, then it means that
> you already are an expert and actually you barely need to read it!
Well, you anyway need to read the DT binding if you want to add more
nodes that use this magic MBUS_ID() thing, so I believe it makes sense
to have this comment in the binding documentation.
> In order to have less change we could at least put it near the MBUS_ID
> macro and if the mvebu-mbus.txt DT binding too.
Fine with that.
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
More information about the linux-arm-kernel