[RFC PATCH] of: base: add support to get machine model name
sudeep.holla at arm.com
Thu Nov 17 06:08:30 PST 2016
On 17/11/16 13:50, Arnd Bergmann wrote:
> On Thursday, November 17, 2016 11:50:50 AM CET Sudeep Holla wrote:
>> Currently platforms/drivers needing to get the machine model name are
>> replicating the same snippet of code. In some case, the OF reference
>> counting is either missing or incorrect.
>> This patch adds support to read the machine model name either using
>> the "model" or the "compatible" property in the device tree root node.
>> Signed-off-by: Sudeep Holla <sudeep.holla at arm.com>
> I like the idea. One small comment:
Thanks. I prefer it as single patch but it can't be applied to any tree.
Any suggestions on handling this patch to fix the warning in -next ?
>> +int of_machine_get_model_name(const char **model)
>> + int error;
>> + struct device_node *root;
>> + root = of_find_node_by_path("/");
>> + if (!root)
>> + return -EINVAL;
> The global of_root variable points ot this already, and is defined
> in the same file, so I think we can just skip the lookup.
Ah right, will fix it.
More information about the linux-arm-kernel