[PATCH] ARM: ftrace: fix syscall name matching

Rabin Vincent rabin.vincent at axis.com
Tue Nov 15 07:18:27 PST 2016


On Mon, Nov 14, 2016 at 10:40:08AM -0500, Steven Rostedt wrote:
> On Mon, 14 Nov 2016 13:40:17 +0000
> Russell King - ARM Linux <linux at armlinux.org.uk> wrote:
> > On Mon, Nov 14, 2016 at 02:03:45PM +0100, Rabin Vincent wrote:
> > > +static inline bool arch_syscall_match_sym_name(const char *sym,
> > > +					       const char *name)
> > > +{
> > > +	/* Skip sys_ */
> > > +	sym += 4;
> > > +	name += 4;  
> > 
> > Is this really safe?  What guarantees that we can wind forward four
> > bytes here?  If it's always safe, it needs a better comment than just
> > two words.
> 
> I believe it is, but a comment would do well.

I ended up just getting rid of the skip and comparing the whole name
instead.  I've sent a v2.



More information about the linux-arm-kernel mailing list