[PATCH v3 3/3] pinctrl: sunxi: Make sunxi_pconf_group_set use sunxi_pconf_reg helper
Linus Walleij
linus.walleij at linaro.org
Tue Nov 15 01:22:22 PST 2016
On Fri, Nov 11, 2016 at 10:50 AM, Chen-Yu Tsai <wens at csie.org> wrote:
> The sunxi_pconf_reg helper introduced in the last patch gives us the
> chance to rework sunxi_pconf_group_set to have it match the structure
> of sunxi_pconf_(group_)get and make it easier to understand.
>
> For each config to set, it:
>
> 1. checks if the parameter is supported.
> 2. checks if the argument is within limits.
> 3. converts argument to the register value.
> 4. writes to the register with spinlock held.
>
> As a result the function now blocks unsupported config parameters,
> instead of silently ignoring them.
>
> Signed-off-by: Chen-Yu Tsai <wens at csie.org>
> Acked-by: Maxime Ripard <maxime.ripard at free-electrons.com>
Patch applied.
Yours,
Linus Walleij
More information about the linux-arm-kernel
mailing list