[PATCH v3] crypto: arm64/sha2: integrate OpenSSL implementations of SHA256/SHA512
Andy Polyakov
appro at openssl.org
Sun Nov 13 13:23:53 PST 2016
>>> (+ Andy)
>>>
>>> ...
>>>>
>>>> Looking at the generated code, I see references to __ARMEB__ and
>>> __ILP32__.
>>>> The former is probably a bug,
>>
>> Oh! You mean that it should be __AARCH64EB__/__AARCH64EL__!
>
> Indeed:
>
> $ aarch64-linux-gnu-gcc -dM -E - <<<"" |grep AARCH
> #define __AARCH64_CMODEL_SMALL__ 1
> #define __AARCH64EL__ 1
>
> $ aarch64-linux-gnu-gcc -dM -E -mbig-endian - <<<"" |grep AARCH
> #define __AARCH64_CMODEL_SMALL__ 1
> #define __AARCH64EB__ 1
As it turns out it wasn't really an overlook, at least not in OpenSSL
context, as I force __ARMEB__/__ARMEL__ in 64-bit build through
arm_arch.h, which in turn is shared between 32- and 64-bit builds. But
shared code should be preferred to be self-sufficient. It doesn't mean
that it won't be fixed, only that it wasn't really a bug in OpenSSL context.
More information about the linux-arm-kernel
mailing list