[PATCH RFC 4/7] ASoC: samsung: i2s: Do not use platform_data for DMA parameters

Arnd Bergmann arnd at arndb.de
Mon Nov 7 13:14:34 PST 2016


On Monday, November 7, 2016 5:02:54 PM CET Sylwester Nawrocki wrote:
> On 11/05/2016 12:29 AM, Arnd Bergmann wrote:
> > On Friday 04 November 2016, Sylwester Nawrocki wrote:
> >> > -       ret = samsung_asoc_dma_platform_register(&pdev->dev, pri_dai->filter,
> >> > +       ret = samsung_asoc_dma_platform_register(&pdev->dev, NULL,
> >> >                                                  NULL, NULL);
> >
> > If we remove the filter argument from every caller here, maybe we should also
> > change the prototype to not expect those three NULL arguments any more.
> 
> There is one occurrence where the third argument needs to be not NULL.
> I'm planning to modify sound/sound/samsung/i2s.c so there is no need
> to create another platform device just for the overlay DAI, afterwards
> the above function could be simplified.

Ok, sounds good.

	Arnd



More information about the linux-arm-kernel mailing list