[PATCH RFC 1/7] dma: pl08x: Add support for the DMA slave map

Arnd Bergmann arnd at arndb.de
Fri Nov 4 16:26:49 PDT 2016


On Friday 04 November 2016, Sylwester Nawrocki wrote:
> +       } else {
> +               pl08x->slave.filter.map = pl08x->pd->slave_map;
> +               pl08x->slave.filter.mapcnt = pl08x->pd->slave_map_len;
>         }

I think you miss the setup of the filter function here.

Filtering by string in this driver is a bit awkward, so I wonder if we
might want to go one step further here and pass the actual data (i.e. 
struct pl08x_channel_data) rather than the string here.

	Arnd



More information about the linux-arm-kernel mailing list